Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid destructuring connectionData when value is undefined #33348

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 24, 2024

Backport of #33339

@dionisio-bot dionisio-bot bot requested review from a team as code owners September 24, 2024 19:57
@dionisio-bot dionisio-bot bot requested a review from KevLehman September 24, 2024 19:57
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 889c0bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Sep 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (ac00085) to head (889c0bb).
Report is 1 commits behind head on release-6.12.2.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.12.2   #33348   +/-   ##
===============================================
  Coverage           58.71%   58.71%           
===============================================
  Files                2682     2682           
  Lines               65011    65011           
  Branches            14603    14603           
===============================================
  Hits                38169    38169           
  Misses              24366    24366           
  Partials             2476     2476           
Flag Coverage Δ
unit 77.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Sep 25, 2024
@kodiakhq kodiakhq bot merged commit 278cf17 into release-6.12.2 Sep 25, 2024
59 of 62 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.12.2-33339 branch September 25, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants